[e2e] TIP pers: Fix Simulation run checks#9043
Merged
odeimaiz merged 2 commits intoITISFoundation:masterfrom Apr 20, 2026
Merged
[e2e] TIP pers: Fix Simulation run checks#9043odeimaiz merged 2 commits intoITISFoundation:masterfrom
odeimaiz merged 2 commits intoITISFoundation:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TIP personalized plan Playwright E2E test to tolerate missing button <i> icons when checking for simulation/export completion, aiming to reduce flakiness around export/setup button state detection.
Changes:
- Wrap setup button icon evaluation in a
try/except PlaywrightErrorand treat missing icon as “likely completed”. - Wrap export button icon evaluation in a
try/except PlaywrightErrorand treat missing icon as “likely completed”.
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo and
pcrespov
matusdrobuliak66
approved these changes
Apr 20, 2026
|
giancarloromeo
approved these changes
Apr 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9043 +/- ##
==========================================
- Coverage 86.33% 82.52% -3.81%
==========================================
Files 2004 1965 -39
Lines 78474 75884 -2590
Branches 1451 1451
==========================================
- Hits 67751 62624 -5127
- Misses 10318 12848 +2530
- Partials 405 412 +7
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When the button icon element disappears from the DOM after the simulation/export finishes it means that the Simulations finished and the Export is done. This PR fixes those handles.
Related issue/s
How to test
Dev-ops